fajri/BE_IBL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix order location duplicates

Browse Source
This commit is contained in:
sas.fajri
2026-05-24 10:22:09 +07:00
parent ebfb56d351
commit 58e50dc498
2 changed files with 83 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
application/controllers/mockup/fo/cashiernewpayment-v27/Payment.php
View File

@@ -579,37 +579,43 @@ class Payment extends MY_Controller
}
}
function save_control()
{
if (! $this->isLogin) {
$this->sys_error("Invalid Token");
exit;
}
$prm = $this->sys_input;
$userid = $this->sys_user['M_UserID'];
if ($prm['data'] && count($prm['data']) > 0) {
foreach ($prm['data'] as $key => $value) {
$sql = "INSERT INTO t_order_location (
T_OrderLocationT_OrderHeaderID,
T_OrderLocationM_LocationID,
T_OrderLocationT_SampleStationID,
T_OrderLocationCreated,
T_OrderLocationLastUpdated,
T_OrderLocationUserID
)
VALUES (?,?,?,NOW(),NOW(),?)
ON DUPLICATE KEY
UPDATE T_OrderLocationT_OrderHeaderID = ?,
T_OrderLocationM_LocationID = ?,
T_OrderLocationT_SampleStationID = ?,
T_OrderLocationLastUpdated = NOW(),
T_OrderLocationUserID = ?";
$query = $this->db_onedev->query($sql, array($value['order_id'], $value['location_id'], $value['station_id'], $userid, $value['order_id'], $value['location_id'], $value['station_id'], $userid));
}
$this->sys_ok(["datas" => '']);
} else {
$this->sys_error_db("data not valid", $this->db_onedev);
exit;
function save_control()
{
if (! $this->isLogin) {
$this->sys_error("Invalid Token");
exit;
}
$prm = $this->sys_input;
$userid = $this->sys_user['M_UserID'];
if ($prm['data'] && count($prm['data']) > 0) {
foreach ($prm['data'] as $key => $value) {
$sql = "UPDATE t_order_location
SET
T_OrderLocationIsActive = 'N',
T_OrderLocationLastUpdated = NOW(),
T_OrderLocationUserID = ?
WHERE
T_OrderLocationT_OrderHeaderID = ? AND
T_OrderLocationT_SampleStationID = ? AND
T_OrderLocationIsActive = 'Y'";
$this->db_onedev->query($sql, array($userid, $value['order_id'], $value['station_id']));
$sql = "INSERT INTO t_order_location (
T_OrderLocationT_OrderHeaderID,
T_OrderLocationM_LocationID,
T_OrderLocationT_SampleStationID,
T_OrderLocationIsActive,
T_OrderLocationCreated,
T_OrderLocationLastUpdated,
T_OrderLocationUserID
)
VALUES (?,?,?,'Y',NOW(),NOW(),?)";
$query = $this->db_onedev->query($sql, array($value['order_id'], $value['location_id'], $value['station_id'], $userid));
}
$this->sys_ok(["datas" => '']);
} else {
$this->sys_error_db("data not valid", $this->db_onedev);
exit;
}
}

46
sql/manual_changes/2026-05-24-fix-order-location-duplicates.sql Normal file
View File

@@ -0,0 +1,46 @@
-- Make fn_get_location tolerate duplicate active rows and clean existing duplicates.
-- Applied on one_lab.
DROP FUNCTION IF EXISTS fn_get_location;
DELIMITER $$
CREATE FUNCTION fn_get_location(PT_SampleStationID INT, PT_OrderHeaderID INT) RETURNS INT
READS SQL DATA
BEGIN
DECLARE RTN INT DEFAULT 0;
SELECT T_OrderLocationM_LocationID INTO RTN
FROM t_order_location
WHERE T_OrderLocationT_OrderHeaderID = PT_OrderHeaderID
AND T_OrderLocationT_SampleStationID = PT_SampleStationID
AND T_OrderLocationIsActive = 'Y'
ORDER BY T_OrderLocationID DESC
LIMIT 1;
IF RTN = 0 THEN
SELECT M_LocationID INTO RTN
FROM m_location
WHERE M_LocationIsActive = 'Y'
AND M_LocationT_SampleStationID = PT_SampleStationID
AND M_LocationPriority = (
SELECT MAX(M_LocationPriority)
FROM m_location
WHERE M_LocationT_SampleStationID = PT_SampleStationID
AND M_LocationIsActive = 'Y'
)
LIMIT 1;
END IF;
RETURN RTN;
END$$
DELIMITER ;
-- Cleanup duplicate active rows so each order + sample station keeps only the newest active row.
UPDATE t_order_location current_row
JOIN t_order_location newest_row
ON newest_row.T_OrderLocationT_OrderHeaderID = current_row.T_OrderLocationT_OrderHeaderID
AND newest_row.T_OrderLocationT_SampleStationID = current_row.T_OrderLocationT_SampleStationID
AND newest_row.T_OrderLocationIsActive = 'Y'
AND newest_row.T_OrderLocationID > current_row.T_OrderLocationID
SET current_row.T_OrderLocationIsActive = 'N',
current_row.T_OrderLocationLastUpdated = NOW()
WHERE current_row.T_OrderLocationIsActive = 'Y';