Fix SQL & Member Eloquent

This commit is contained in:
Muhammad Fajar
2024-01-06 13:52:41 +07:00
parent 494c13aea8
commit eb662f7c34
3 changed files with 14 additions and 3 deletions

View File

@@ -39,7 +39,6 @@ class CorporateMemberController extends Controller
switch ($request->input('type')) { switch ($request->input('type')) {
case 'employee-data': case 'employee-data':
$members = $this->corporateMemberService->getAllMemberEmployeeData($corporate_id, $request); $members = $this->corporateMemberService->getAllMemberEmployeeData($corporate_id, $request);
return response()->json($members);
return response()->json(Helper::paginateResources(DashboardMemberEmployeeDataResources::collection($members))); return response()->json(Helper::paginateResources(DashboardMemberEmployeeDataResources::collection($members)));
case 'claim-report': case 'claim-report':
$members = $this->corporateMemberService->getAllMemberClaimReports($corporate_id, $request); $members = $this->corporateMemberService->getAllMemberClaimReports($corporate_id, $request);

View File

@@ -213,15 +213,25 @@ class Member extends Model
$arr[] = $this->person->name_prefix; $arr[] = $this->person->name_prefix;
} }
$arr[] = $this->person->name ?? '-'; $arr[] = $this->person->name;
if (!empty($this->person->name_suffix)) { if (!empty($this->person->name_suffix)) {
$arr[] = $this->person->name_suffix; $arr[] = $this->person->name_suffix;
} }
} else {
if (!empty($this->name_prefix)) {
$arr[] = $this->name_prefix;
}
$arr[] = $this->name;
if (!empty($this->name_suffix)) {
$arr[] = $this->name_suffix;
}
} }
return Attribute::make( return Attribute::make(
get: fn () => !empty($arr) ? ucwords(strtolower(implode(' ', $arr))) : null get: fn () => $arr ? ucwords(strtolower(implode(' ', $arr))) : null
); );
} }

View File

@@ -227,6 +227,8 @@ class CorporateMemberService
'id', 'id',
'person_id', 'person_id',
'member_id', 'member_id',
'name_prefix',
'name_suffix',
'name', 'name',
'members_effective_date', 'members_effective_date',
'members_expire_date', 'members_expire_date',